-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixes and extensions to symmetric meta programming docs #3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:
- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Added" instead of "Add")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
607788c
to
9258079
Compare
docs/docs/reference/simple-smp.md
Outdated
@@ -0,0 +1,229 @@ | |||
# Simple Symmetric Metaprogramming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should have a header like I added in #3696
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems still a problem, and why http://dotty.epfl.ch/docs/simple-smp.html is still a dead link. Fixing. EDIT: http://dotty.epfl.ch/docs/reference/simple-smp.html is fine, the problem's in the link it seems, I'll look into it.
80c54f1
to
043b5fd
Compare
docs/docs/reference/simple-smp.md
Outdated
|
||
This note presents a simplified variant of symmetric meta-programming | ||
and sketches its soundness proof. The variant treats only dialogues | ||
between two stages. A program can have quotes which can contain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space
docs/docs/reference/simple-smp.md
Outdated
and sketches its soundness proof. The variant treats only dialogues | ||
between two stages. A program can have quotes which can contain | ||
splices (which can contain quotes, which can contain splices, and so | ||
on). Or the program could start with a splice with embedded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space
docs/docs/reference/simple-smp.md
Outdated
|
||
23.12.2017 | ||
|
||
This note presents a simplified variant of symmetric meta-programming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a link to the symmetric meta-programming
doc here.
@@ -15,4 +15,5 @@ abstract class Liftable[T] { | |||
object Liftable { | |||
implicit def IntIsLiftable: Liftable[Int] = ??? | |||
implicit def BooleanIsLiftable: Liftable[Boolean] = ??? | |||
implicit def StringIsLiftable: Liftable[String] = ??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already added along with all other constants
with a sketch of its meta theory.
Make sure `assertImpl` prints the tested expression rather than its result.
No description provided.